feature/ruby-http #472
Merged
feature/ruby-http #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
baywet
reviewed
Aug 11, 2021
baywet
reviewed
Aug 12, 2021
baywet
reviewed
Aug 12, 2021
http/ruby/nethttp/microsoft_kiota_nethttp/lib/microsoft_kiota_nethttp/http_core.rb
Outdated
Show resolved
Hide resolved
…to reference the abstractions package
…rameters as well as the api_client_builder
…function with generated code and http api - Bumped the Version to 0.1.3
…wait when fetching the auth token
…n - added UUIDtools as a gem dependency
…, updated all class properties to include module namespaces, updated unit tests accordingly
baywet
requested changes
Aug 13, 2021
...ons/ruby/microsoft_kiota_abstractions/lib/microsoft_kiota_abstractions/api_client_builder.rb
Outdated
Show resolved
Hide resolved
http/ruby/nethttp/microsoft_kiota_nethttp/lib/microsoft_kiota_nethttp/http_core.rb
Show resolved
Hide resolved
http/ruby/nethttp/microsoft_kiota_nethttp/lib/microsoft_kiota_nethttp/http_core.rb
Show resolved
Hide resolved
http/ruby/nethttp/microsoft_kiota_nethttp/lib/microsoft_kiota_nethttp/http_core.rb
Outdated
Show resolved
Hide resolved
http/ruby/nethttp/microsoft_kiota_nethttp/lib/microsoft_kiota_nethttp/http_core.rb
Show resolved
Hide resolved
abfarah
requested review from
andrueastman,
darrelmiller,
ddyett and
MIchaelMainer
as code owners
abfarah
requested review from
nikithauc,
peombwa,
ramsessanchez and
zengin
as code owners
baywet
approved these changes
Aug 16, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby language Core Library http using net/http implementation
issue #419