Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/raw collections #480

Merged
merged 12 commits into from
Aug 13, 2021
Merged

bugfix/raw collections #480

merged 12 commits into from
Aug 13, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Aug 12, 2021

  • fixes a bug where sending collections of objects would not be supported in CSharp
  • fixes a bug in CSharp were primitive types would map to the wrong http core method
  • adds an overload for collections in dotnet httpcore
  • fixes a bug in dotnet generation where raw collections would not be mapped properly
  • fixes a bug in java where raw collections requests would not be supported
  • fixes a bug for typescript where raw collections would not be supported
  • fixes a bug where body types would not be imported
  • fixes support for raw collections in ruby

fixes #467

Generation diff

microsoft/kiota-samples#212

@baywet baywet added this to the Beta milestone Aug 12, 2021
@baywet baywet self-assigned this Aug 12, 2021
@baywet baywet enabled auto-merge August 12, 2021 17:27
@baywet baywet mentioned this pull request Aug 12, 2021
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.1% 85.1% Coverage
0.0% 0.0% Duplication

baywet added a commit that referenced this pull request Aug 12, 2021
@baywet
- aligns set content from parsable parameters order to changes from #…
a821d18 
…480
@baywet baywet mentioned this pull request Aug 12, 2021
Merged
@baywet baywet disabled auto-merge August 13, 2021 11:57
@baywet baywet merged commit 57a1087 into main Aug 13, 2021
@baywet baywet deleted the bugfix/raw-collections branch August 13, 2021 11:57
baywet added a commit that referenced this pull request Aug 13, 2021
@baywet
- aligns set content from parsable parameters order to changes from #…
54e055f 
…480
baywet added a commit that referenced this pull request Aug 16, 2021
@baywet
- aligns set content from parsable parameters order to changes from #…
cd4db01 
…480
baywet added a commit that referenced this pull request Aug 17, 2021
@baywet
- aligns set content from parsable parameters order to changes from #…
fb3f030 
…480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengin zengin zengin approved these changes

@abfarah abfarah Awaiting requested review from abfarah

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
Alpha-2
Development

Successfully merging this pull request may close these issues.

add support for non-wrapped collections responses
2 participants
@baywet @zengin