-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code generation for Dart #5966
Conversation
This code is not nearly finished, but was pushed to work simultaneously on this code base. Using a DartRefiner that is created from scratch. In the end this will be our actual refiner, and we will update ILanguage to reflect this.
Also added imprts for properties and methods. Tjose imports are not correct yet.
Imports in other files are still incorrect.
No idea if it actually works, but at least it compiles.
Added more Dart syntax to creating methods.
createFromDiscriminatorValue also looks correct.
…hods and properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for the great work! And special thanks to @ricardoboss for ensuring we cross the finish line on this project!
@andrueastman @Ndiritu I'm going to ask that both of you review this PR. I've already reviewed it on the fork, and I was coaching the team as well. So getting additional pair of eyes will be paramount here.
The idea is to try and make it for the minor release on the 9th, no rush though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the current failures in the integration tests expected for now and to be resolved in a separate PR?
Not really, they are a side-effect of recent changes in the Dart packages. I've created a separate PR to fix this: https://github.com/kiota-community/kiota-dart/pull/4 Additionally, I discovered a bug that also has a separate PR to fix it: https://github.com/kiota-community/kiota-dart/pull/3 |
also updated the min environment version and dependencies
…event version resolution
The name used for the URL template needs to match the serialized name of the custom parameter.
@andrueastman I applied all your suggestions. Thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Adds code generation for the Dart programming language.
This PR was a joint effort and contains lots of good work by @joanne-ter-maat and @Kees-Schotanus and is the result of lots of iterations and review over at https://github.com/kiota-community/kiota-dart/pull/1 by @baywet and @andreaTP.
Fixes #3745.