Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Remove deprecated type aliases from generated code for python 3.9+. #5974

Merged
merged 9 commits into from
Jan 13, 2025
Merged

[Python] Remove deprecated type aliases from generated code for python 3.9+. #5974

merged 9 commits into from
Jan 13, 2025
+35 −26

Conversation

andrueastman
Copy link
Member

Partial of microsoft/kiota-python#349

Related to microsoft/kiota-python#433

Drops deprecated type hints used in python 3.9+.

@andrueastman andrueastman mentioned this pull request Jan 9, 2025
Merged
@andrueastman
Copy link
Member Author

Sample generation at #5974

@andrueastman andrueastman mentioned this pull request Jan 9, 2025
Closed
3 tasks
@andrueastman
Copy link
Member Author

Depends on release of microsoft/kiota-python#433

@andrueastman andrueastman changed the title Remove deprecated type aliases from generated code. [Python] Remove deprecated type aliases from generated code for python 3.9+. Jan 9, 2025
baywet
baywet previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good with those changes. I did leave a comment on the test generation PR. I think a regression was introduced some time ago. Not sure whether we want to address it now or as part of a separate PR.

CHANGELOG.md Outdated Show resolved Hide resolved
@andrueastman andrueastman mentioned this pull request Jan 13, 2025
Merged
@andrueastman andrueastman marked this pull request as ready for review January 13, 2025 07:49
@andrueastman andrueastman requested a review from a team as a code owner January 13, 2025 07:49
@andrueastman andrueastman requested a review from baywet January 13, 2025 07:49
@andrueastman
Copy link
Member Author

mostly good with those changes. I did leave a comment on the test generation PR. I think a regression was introduced some time ago. Not sure whether we want to address it now or as part of a separate PR.

Addressed in the PR with this change 98971c7

baywet
baywet reviewed Jan 13, 2025
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@andrueastman andrueastman merged commit 1e59299 into main Jan 13, 2025
243 checks passed
@andrueastman andrueastman deleted the andrueastman/python3.9 branch January 13, 2025 13:06
@andrueastman andrueastman mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet