Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for url templating #683

Merged
merged 38 commits into from
Oct 27, 2021
Merged

adds support for url templating #683

merged 38 commits into from
Oct 27, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 5, 2021 •
edited
Loading

summary

fixes #628

generation diff

microsoft/kiota-samples#331

@baywet baywet added this to the TypeWriter Replacement milestone Oct 5, 2021
@baywet baywet self-assigned this Oct 5, 2021
@baywet baywet added Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code Ruby labels Oct 5, 2021
@baywet baywet linked an issue Oct 5, 2021 that may be closed by this pull request
URL templating support #628
Closed
6 tasks
Base automatically changed from feature/renames to main October 6, 2021 12:14
@baywet baywet force-pushed the feature/url-template branch from 599b29a to 57e7ca8 Compare October 6, 2021 13:39
This was referenced Oct 6, 2021
Merged
Closed
baywet added 16 commits October 20, 2021 09:37
@baywet
- switches to url templates for dotnet generation
96488d0
@baywet
- fixes wrong expected url value
de6b364
@baywet
- adds support for query string parameters in url templates
428976a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds mapping to url template parameter name for go, java, ruby, and…
9758577 
… typescript

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- assigns path parameters in constructor for dotnet
47e0c27 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes parameters validation casing
642c06c 
- fixes url template params reference

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds support for raw urls in dotnet
df299c4 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds support for url templating in java
eab4c5a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes java parameters casing issue
83f680e 
- removes path parameters from raw constructor

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- additional casing corrections for java
2841416
@baywet
- adds support for url template in typescript
df62913 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes a bug where path paremeters could be undefined in typescript …
eadfa09 
…url param
@baywet
- fixes a casing convention for typescript parameters
9d7d49b
@baywet
- fixes enum collections serialization for typescript
8d7a589
@baywet
- adds support for url template for go
2cdad56 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds missing path parameters conversions in go
651bd5d 
- adds missing additional path parameters for raw url constructor in go
- fixes casing conventions in go

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet added 5 commits October 20, 2021 15:55
@baywet
- code-linting
36700f7
@baywet
- fixes cleanup task path
f6fb310 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds unit test for url template changes
a808ba2 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds changelog entry for url template change
ad5beb3 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- bumps path version for url template change
2b408dd 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet marked this pull request as ready for review October 21, 2021 16:40
andrueastman
andrueastman reviewed Oct 22, 2021
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this @baywet.

This looks good to me save for the comments left for now.

CHANGELOG.md Outdated Show resolved Hide resolved
abstractions/dotnet/src/RequestInformation.cs Outdated Show resolved Hide resolved
abstractions/dotnet/Microsoft.Kiota.Abstractions.Tests/RequestInformationTests.cs Show resolved Hide resolved
src/Kiota.Builder/Writers/LanguageWriter.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Extensions/OpenApiUrlTreeNodeExtensions.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/CSharp/CSharpConventionService.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/CSharp/CSharpConventionService.cs Show resolved Hide resolved
src/Kiota.Builder/Writers/TypeScript/TypeScriptConventionService.cs Outdated Show resolved Hide resolved
@baywet baywet requested a review from andrueastman October 25, 2021 13:20
andrueastman
andrueastman approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking in the changes @baywet.

Also note, I have added the commit 26e21b1 to the branch as I discovered that the related test was broken/not compiling.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@baywet
Copy link
Member Author

baywet commented Oct 27, 2021

Thanks for taking the time to fix that! Merging.

@baywet baywet merged commit 629b40d into main Oct 27, 2021
@baywet baywet deleted the feature/url-template branch October 27, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@zengin zengin Awaiting requested review from zengin

Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java Ruby TypeScript Pull requests that update Javascript code
Projects
None yet
Milestone
TypeWriter Replacement
Development

Successfully merging this pull request may close these issues.

URL templating support
2 participants
@baywet @andrueastman