Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeActionOptions with providedCodeActionKinds #534

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add CodeActionOptions with providedCodeActionKinds #534

merged 1 commit into from
Aug 21, 2018

Conversation

Gama11
Copy link
Contributor

@Gama11 Gama11 commented Jul 28, 2018 •
edited

See here for the motivation: #389 (comment)

Corresponding vscode-languageclient PR: microsoft/vscode-languageserver-node#385

This was referenced Jul 28, 2018
Merged
Closed
@dbaeumer
Copy link
Member

Adding this makes complete sense to me.

@dbaeumer dbaeumer merged commit 20d0cec into microsoft:gh-pages Aug 21, 2018
@Gama11 Gama11 deleted the codeActionOptions branch August 21, 2018 09:29
@dbaeumer
Copy link
Member

I renamed the property to codeActionKinds to make it consistent with the LSP naming. We never have provided in the capability name if the server provides something. The provide is already part of the top level naming (e.g. codeActionProvider)

@Gama11
Copy link
Contributor Author

Gama11 commented Aug 21, 2018

Make sense! My original naming was consistent with the VSCode API, but consistency with the LSP indeed seems more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gama11 @dbaeumer