Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malmo's internal Minecraft client/server message system can't send more than 64k per message #52

Closed
DaveyBiggers opened this issue Jun 6, 2016 · 1 comment
Closed

Malmo's internal Minecraft client/server message system can't send more than 64k per message #52

DaveyBiggers opened this issue Jun 6, 2016 · 1 comment
Assignees
@DaveyBiggers
Labels
P2
Milestone
Alpaca

Comments

@DaveyBiggers
Copy link
Member

MalmoMessage.toBytes() uses ByteBufOutputStream.writeUTF() to encode message data.
From the docs:

First, the total number of bytes needed to represent all the characters of s is calculated. If this number is larger than 65535, then a UTFDataFormatException is thrown.

Alas, the limit of 65535 can easily be surpassed by requesting a large grid observation (21x21x21 will do it, depending on the blocktypes of the terrain). The effect in this case is that the observations never reach the agent.
@DaveyBiggers DaveyBiggers added the P2 label Jun 6, 2016
@DaveyBiggers DaveyBiggers self-assigned this Jun 6, 2016
DaveyBiggers added a commit that referenced this issue Jun 7, 2016
@DaveyBiggers
Added ability to write strings longer than 64k in message data (issue #…
8b05780 
…52)
@katja-hofmann katja-hofmann modified the milestone: Alpaca Jun 7, 2016
DaveyBiggers added a commit that referenced this issue Jun 8, 2016
@DaveyBiggers
Merge pull request #54 from Microsoft/LongStringFix
8c0c47f 
Added ability to write strings > than 64k in message data (issue #52)
@DaveyBiggers
Copy link
Member Author

Fixed in 8c0c47f
We now use four bytes to represent the length of the string, rather than two.

@DaveyBiggers DaveyBiggers mentioned this issue Jun 9, 2016
Closed
DaveyBiggers added a commit that referenced this issue Jun 16, 2016
@DaveyBiggers
Added ability to write strings longer than 64k in message data (issue #…
de6a696 
…52)
@JustinS6626 JustinS6626 mentioned this issue Mar 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaveyBiggers DaveyBiggers

Labels
P2
Projects
None yet
Milestone
Alpaca
Development

No branches or pull requests
2 participants
@DaveyBiggers @katja-hofmann