Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support images in table #284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lh0x00
Copy link

@lh0x00 lh0x00 commented Jan 15, 2025

Pull Request Description

Summary

This PR enhances _CustomMarkdownify with a feature:

  1. Inline Images in Table Elements:
    • Keeps inline images within td, tr, div, p, and span elements.

Changes

  • Updated options to include keep_inline_images_in.

Thank you for reviewing!

@lh0x00
Copy link
Author

lh0x00 commented Jan 15, 2025

@microsoft-github-policy-service agree

@lh0x00
Copy link
Author

lh0x00 commented Jan 15, 2025

@gagb @afourney I find it useful when working with LLM applications (assistants, research, etc.), so I recommend it. What do you think?

@afourney
Copy link
Member

afourney commented Feb 9, 2025

This looks promising. A few requests. Can you break this into to PRs? One for testing the language, and the other for keeping in-line images.

Can you use the pre-commit hook to format the files before commit.

And can you add test cases for each update?

Thanks again for the contribution!

@afourney afourney added the awaiting op response The PR is awaiting response/edits from the original poster. label Feb 9, 2025
@lh0x00 lh0x00 force-pushed the feature/EnhanceMarkdownify branch from ec99832 to 95da5fd Compare February 10, 2025 12:00
@lh0x00 lh0x00 changed the title feat: support images in table and auto detect code languages (optional) feat: support images in table Feb 10, 2025
@lh0x00
Copy link
Author

lh0x00 commented Feb 10, 2025

@afourney I have separated into separate PRs, #319. Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting op response The PR is awaiting response/edits from the original poster.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants