Skip to content

Commit

Permalink
Make NavigationView SettingsItem Tag not localized (#6769)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelwgn authored Mar 2, 2022
1 parent b8eb652 commit 05a0b06
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dev/NavigationView/NavigationView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ static constexpr auto c_navViewCloseButton = L"NavigationViewCloseButton"sv;
static constexpr auto c_navViewCloseButtonToolTip = L"NavigationViewCloseButtonToolTip"sv;
static constexpr auto c_paneShadowReceiverCanvas = L"PaneShadowReceiver"sv;
static constexpr auto c_flyoutRootGrid = L"FlyoutRootGrid"sv;
static constexpr auto c_settingsItemTag = L"Settings"sv;

// DisplayMode Top specific items
static constexpr auto c_topNavMenuItemsHost = L"TopNavMenuItemsHost"sv;
Expand Down Expand Up @@ -1317,7 +1318,7 @@ void NavigationView::CreateAndHookEventsToSettings()
// Do localization for settings item label and Automation Name
auto localizedSettingsName = ResourceAccessor::GetLocalizedStringResource(SR_SettingsButtonName);
winrt::AutomationProperties::SetName(settingsItem, localizedSettingsName);
settingsItem.Tag(box_value(localizedSettingsName));
settingsItem.Tag(box_value(c_settingsItemTag));
UpdateSettingsItemToolTip();

// Add the name only in case of horizontal nav
Expand Down

0 comments on commit 05a0b06

Please sign in to comment.