Updating ProgressRing to not report the RangeValue pattern when it's …

…indeterminate. (#6941) ProgressRing should not report the RangeValue pattern when it's indeterminate, as in that case it has no value to report.
microsoft · Apr 7, 2022 · 93d7e3a · 93d7e3a
1 parent e59614e
commit 93d7e3a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/dev/ProgressRing/InteractionTests/ProgressRingTests.cs b/dev/ProgressRing/InteractionTests/ProgressRingTests.cs
@@ -46,7 +46,7 @@ public void TestCleanup()
         }
 
         [TestMethod]
-         public void ChangeStateTest()
+        public void ChangeStateTest()
         {
             using (var setup = new TestSetupHelper("ProgressRing Tests"))
             {
@@ -93,7 +93,7 @@ public void ChangeStateTest()
                 Log.Comment("IsActive set to false updates ProgressRing to Inactive state");
 
                 isActiveCheckBox.ToggleAndWait();
-                
+
                 Verify.AreEqual("Inactive", visualStateText.DocumentText);
 
                 Log.Comment("Verify Lottie animation is not playing when in Inactive state");
@@ -298,5 +298,20 @@ public void UpdateMinMaxTest()
                 Verify.IsGreaterThan(diff, Convert.ToDouble(0), "Value of ProgressBar increments properly within range with decimal Minimum and Maximum");
             }
         }
+
+        [TestMethod]
+        public void VerifyIndeterminateProgressRingDoesNotImplementRangeValuePattern()
+        {
+            using (var setup = new TestSetupHelper("ProgressRing Tests"))
+            {
+                UIObject progressRing = FindElement.ByName("Busy TestProgressRing");
+
+                Verify.IsNotNull(progressRing);
+
+                RangeValueImplementation rangeValueImplementation = new RangeValueImplementation(progressRing);
+
+                Verify.IsFalse(rangeValueImplementation.IsAvailable);
+            }
+        }
     }
 }
diff --git a/dev/ProgressRing/ProgressRingAutomationPeer.cpp b/dev/ProgressRing/ProgressRingAutomationPeer.cpp
@@ -19,7 +19,14 @@ winrt::IInspectable ProgressRingAutomationPeer::GetPatternCore(winrt::PatternInt
 {
     if (patternInterface == winrt::PatternInterface::RangeValue)
     {
-        return *this;
+        if (GetImpl()->IsIndeterminate())
+        {
+            return nullptr;
+        }
+        else
+        {
+            return *this;
+        }
     }
 
     return __super::GetPatternCore(patternInterface);