Reduce default NumberBox precision to 6 digits (#7851)

microsoft · Dec 2, 2022 · b4e5f2c · b4e5f2c
1 parent 6a83c31
commit b4e5f2c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/dev/NumberBox/NumberBox.cpp b/dev/NumberBox/NumberBox.cpp
@@ -207,8 +207,10 @@ void NumberBox::OnApplyTemplate()
 
     m_isEnabledChangedRevoker = IsEnabledChanged(winrt::auto_revoke, { this,  &NumberBox::OnIsEnabledChanged });
 
-    // .NET rounds to 12 significant digits when displaying doubles, so we will do the same.
-    m_displayRounder.SignificantDigits(12);
+    // printf() defaults to 6 digits. 6 digits are sufficient for most
+    // users under most circumstances, while simultaneously avoiding most
+    // rounding errors for instance during double/float conversion.
+    m_displayRounder.Increment(1e-6);
 
     UpdateSpinButtonPlacement();
     UpdateSpinButtonEnabled();

diff --git a/dev/NumberBox/NumberBox.h b/dev/NumberBox/NumberBox.h
@@ -98,7 +98,7 @@ class NumberBox :
     bool m_valueUpdating{ false };
     bool m_textUpdating{ false };
 
-    winrt::SignificantDigitsNumberRounder m_displayRounder{};
+    winrt::IncrementNumberRounder m_displayRounder{};
 
     tracker_ref<winrt::TextBox> m_textBox{ this };
     tracker_ref<winrt::ContentPresenter> m_headerPresenter{ this };