Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoSuggestBox] PlaceholderText does not vertically align to the center #5957

Closed
niels9001 opened this issue Sep 24, 2021 · 6 comments · Fixed by #5968
Closed

[AutoSuggestBox] PlaceholderText does not vertically align to the center #5957

niels9001 opened this issue Sep 24, 2021 · 6 comments · Fixed by #5968
Labels
area-AutoSuggestBox team-Controls Issue for the Controls team

Comments

@niels9001
Copy link
Contributor

niels9001 commented Sep 24, 2021 •
edited
Loading

Describe the bug
The PlaceholderText in the AutoSuggestBox is not vertically aligned. This requires devs to go into the control template to fix it which isn't productive

Steps to reproduce the behavior

  1. Add AutoSuggestBox with a PlaceholderText and increase the height.
  2. See the result

<AutoSuggestBox PlaceholderText="Replace with" Height="48" Padding="12,12,0,0" VerticalAlignment="Center" VerticalContentAlignment="Center" />

Expected behavior
PlaceholderText should vertically align, like the actual Text in AutoSuggestBox itself. TextBox does this correctly.

Screenshots
PlaceholderText:

image

Actual text:
image

Version Info
C++, Xaml Islands, 2.7.0-prerelease.210913003

Windows version Saw the problem?
May 2021 Update (19043) Yes
Device form factor Saw the problem?
Desktop Yes
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 24, 2021
@niels9001
Copy link
Contributor Author

@chingucoding Do you know if there's a lightweight setting to do this? Or only overriding the template for the entire thing? Seems to be a similar issue like the one with the misaligned x or search icon?

@marcelwgn
Copy link
Contributor

I'm afraid there is not much you can do here @niels9001 . You can pretty much only retemplate the control to fix this bug. The fix would be to set the VerticalContentAlignment of the placeholder presenter. If the team's fine with that, I would like to fix this.

@marcelwgn marcelwgn mentioned this issue Sep 25, 2021
Merged
@ghost ghost added the working on it label Sep 25, 2021
@ranjeshj ranjeshj added area-AutoSuggestBox team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 29, 2021
@ghost ghost removed the working on it label Oct 11, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-AutoSuggestBox team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
3 participants
@niels9001 @marcelwgn @ranjeshj