Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoSuggestBox] Make placeholder respect vertical and horizontal content alignment properties #5968

Merged
merged 5 commits into from
Oct 11, 2021
Merged

[AutoSuggestBox] Make placeholder respect vertical and horizontal content alignment properties #5968

merged 5 commits into from
Oct 11, 2021

Conversation

marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Sep 25, 2021 •
edited
Loading

Description

Make placeholder respect vertical and horizontal content alignment properties to avoid weird visuals when modifying height of AutoSuggestBox

Motivation and Context

Closes #5957

How Has This Been Tested?

Tested manually.

Screenshots (if appropriate):

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 25, 2021
@marcelwgn marcelwgn changed the title [AutoSuggestBox] Make placeholder vertically centered [AutoSuggestBox] Make placeholder respect vertical and horizontal content alignment properties Sep 26, 2021
@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

/azp run

@StephenLPeters StephenLPeters added area-AutoSuggestBox team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 27, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

@chingucoding hmm looks like your verification file updates weren't quite right... Maybe there is something broken with the visual verification updater script?

@marcelwgn
Copy link
Contributor Author

@StephenLPeters I'm fairly sure the script is broken, however i am not sure in which way. Is that worth opening an issue?

Also updated the verification files again (hopefully correctly this time).

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

Yeah, the versions generated for this new run are identical, something is broken... :/

@marcelwgn
Copy link
Contributor Author

Strangely, CI passed now🤔

@StephenLPeters
Copy link
Contributor

I don't think we should block on this but we need to investigate... mind opening an issue? :)

@StephenLPeters StephenLPeters merged commit f7d3364 into microsoft:main Oct 11, 2021
@marcelwgn marcelwgn mentioned this pull request Oct 11, 2021
Closed
@niels9001
Copy link
Contributor

@ranjeshj Any estimation when this will be shipping in a pre-release package?

@niels9001 niels9001 mentioned this pull request Nov 23, 2021
Merged
10 tasks
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Apr 14, 2022
Closed
Closed
@ghost ghost mentioned this pull request Apr 14, 2022
Merged
@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxk roxk roxk left review comments

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-AutoSuggestBox team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AutoSuggestBox] PlaceholderText does not vertically align to the center
5 participants
@marcelwgn @ranjeshj @StephenLPeters @niels9001 @roxk