[PowerRename] Resolve UI focus issue #14605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
reviewed
Nov 24, 2021
stefansjfw
reviewed
Nov 24, 2021
stefansjfw
approved these changes
Nov 24, 2021
|
@jaimecbernardo This want would be nice to have as part of 0.51 :). |
|
@niels9001 , sounds good. Feel free to merge it in once checks are done ;) |
|
Thank you for the contribution! |
|
Looks like this just made it in. @jaimecbernardo can we cherry pick this into stable for v0.51? |
@dedavis6797 Yes, that's the idea. Just fixing those pipelines first and then I'll sync stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR removes a vertical ScrollViewer that caused bad focus behavior. Removed custom AutoSuggestBox style. The i button is now next to the textbox to resolve an issue where the clear button was not correctly aligned.
It also introduces a regression: the placeholder text is not vertically aligned. This will be fixed in the next WinUI update however: microsoft/microsoft-ui-xaml#5968. I believe this is fine for now, and allows us to not have a complex custom style.
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.