Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUX Experimental: ResourceAccessor::GetLocalizedStringResourceFromWinUI has hardcoded string for WinUI 2.6 #6242

Closed
kmahone opened this issue Nov 5, 2021 · 0 comments · Fixed by #6265
Assignees

Comments

@kmahone
Copy link
Member

kmahone commented Nov 5, 2021

In the MUX Experimental dll, ResourceAccessor::GetLocalizedStringResourceFromWinUI is used to lookup localized resources from the regular WinUI package.

This initially used the MUXCONTROLS_PACKAGE_NAME macro to get string. But after merging the latest from main branch, this no longer works, since main is on 2.8, but Experimental is tied to 2.6.

We need to rationalize how versioning works with Experimental depending on the main WinUI package

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 5, 2021
@ghost ghost added the working on it label Nov 9, 2021
@ghost ghost removed needs-triage Issue needs to be triaged by the area owners working on it labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants