MUX Experimental: Remove hard-coded package version from GetLocalizedStringResourceFromWinUI #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
teaP
approved these changes
Nov 10, 2021
StephenLPeters
added
area-DevInternal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was using a hardcoded string to look up resources from Microsoft.UI.Xaml.2.6 framework package. This means that Microsoft.Experimental.UI.Xaml nuget package could only be used with WinUI 2.6 release. This PR updates the code to find any Microsoft.UI.Xaml.* framework package to use for finding localized resources.
This also ensures that Microsoft.Experimental.UI.Xaml.pdb debugging symbols get published to the drop in the Pipeline.
Closes #6242