Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide effect of SlideNavigationTransitionInfo goes over another control #8785

Closed
Tracked by #8762
yki5000 opened this issue Aug 24, 2023 · 3 comments
Closed
Tracked by #8762
Labels
bug Something isn't working

Comments

@yki5000
Copy link

yki5000 commented Aug 24, 2023

Describe the bug

I added it in the xaml but the sliding effect seems broken, it goes over the navigation bar.
It looks less bad, if I add the effect in code and not as xaml TransitionCollection.

Look here, tested in C++ and C#, same result:

yki5000/WinUI3_Unpackaged_CPP#3

I'm on 1.3. (only use stable versions but I don't know, if this version is officially supportet because it works in the WinUI 3 gallery)

Steps to reproduce the bug

  1. Create an unpackaged app.
  2. Create a page with some test content.
  3. Add a frame to the main window.
  4. Add a NavigationView to the main window (left compact design).
  5. Add the TransitionCollection to the frame.
<Frame.ContentTransitions>
	<TransitionCollection>
		<EdgeUIThemeTransition Edge="Left">
		</EdgeUIThemeTransition>	
	</TransitionCollection>
</Frame.ContentTransitions>
  1. Test the navigation by the navigate method, you should see the error.
  2. For the second test just remove the TransitionCollection from the frame and add the following code and adjust it. The error is still there but it looks less bad.

// Create the slide transition and set the transition effect to FromRight.
SlideNavigationTransitionInfo slideEffect = SlideNavigationTransitionInfo();
slideEffect.Effect(SlideNavigationTransitionEffect(SlideNavigationTransitionEffect::FromRight));
Frame().Navigate(winrt::xaml_typenameBasicNavigation::Page2(),winrt::box_value(name().Text()),slideEffect);

Expected behavior

Slide effect of SlideNavigationTransitionInfo should not go over an other control.

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.3.3: 1.3.230724000

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

@yki5000 yki5000 added the bug Something isn't working label Aug 24, 2023
@yki5000 yki5000 changed the title Slide effect of SlideNavigationTransitionInfo goes over an other control Slide effect of SlideNavigationTransitionInfo goes over another control Aug 24, 2023
@yki5000
Copy link
Author

yki5000 commented Aug 25, 2023

If you look on my page, I tested it in c#, same result.

@lhak
Copy link

lhak commented Aug 27, 2023

Have you tried putting the frame into the NavigationView.Content section?

@yki5000
Copy link
Author

yki5000 commented Oct 7, 2023

@ihak, thank you.
The NavigationView was not implemented correctly by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants