-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigationView not updating UIA users about changed selection and expand state #2692
NavigationView not updating UIA users about changed selection and expand state #2692
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@StephenLPeters Is there any way we could test these kind of behaviors through an automatic test? I haven't found a way how we could listen to these changes, but maybe I haven't look in the right spots. In the long term of course it would be better to have this be tested automatically and not rely on manual testing. |
restrict the scope of the change to ensure the proper timing of scope guarded flag set.
@chingucoding could you fix the merge conflict |
Fixed now. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@kmahone as FYI. This might be something that we are missing in the test framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Handy links: |
Description
For UIA to be register when the selection and expand state changed, we need to raise the appropriate events at the right time.
Motivation and Context
Closes #2599
How Has This Been Tested?
Expand/Collapse: Manually tested
Selection: Manually tested, not working
Open Questions:
How do we test this automatically? I haven't found an event we could listen to in order to verify that we are updating correctly.
Selection updating DOES NOT WORK! I've committed the different variants of what I have tried to get Narrator to read out the new selected item, however those do not work. I haven't found anything else regarding which event/method to use here; TreeView seems to rely on the underlying ListView to handle the selection state.