Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView not updating UIA users about changed selection and expand state #2692

Merged

Conversation

marcelwgn
Copy link
Collaborator

Description

For UIA to be register when the selection and expand state changed, we need to raise the appropriate events at the right time.

Motivation and Context

Closes #2599

How Has This Been Tested?

Expand/Collapse: Manually tested
Selection: Manually tested, not working

Open Questions:

How do we test this automatically? I haven't found an event we could listen to in order to verify that we are updating correctly.

Selection updating DOES NOT WORK! I've committed the different variants of what I have tried to get Narrator to read out the new selected item, however those do not work. I haven't found anything else regarding which event/method to use here; TreeView seems to rely on the underlying ListView to handle the selection state.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 16, 2020
@StephenLPeters StephenLPeters added accessibility Narrator, keyboarding, UIA, etc area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 16, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added this to the WinUI 2.5 milestone Jun 26, 2020
@ranjeshj ranjeshj added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Jun 26, 2020
@marcelwgn
Copy link
Collaborator Author

@StephenLPeters Is there any way we could test these kind of behaviors through an automatic test? I haven't found a way how we could listen to these changes, but maybe I haven't look in the right spots. In the long term of course it would be better to have this be tested automatically and not rely on manual testing.

marcelwgn and others added 2 commits July 2, 2020 02:59
restrict the scope of the change to ensure the proper timing of scope guarded flag set.
@StephenLPeters
Copy link
Contributor

@chingucoding could you fix the merge conflict

@marcelwgn
Copy link
Collaborator Author

@chingucoding could you fix the merge conflict

Fixed now.

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

y way we could test these kind of behaviors through an automatic test? I haven't found a way how we could listen to these changes, but maybe I haven't look in the right spots. In the long term of course it would be better to have this be tested automatically and not rely on manual testing.

@kmahone as FYI. This might be something that we are missing in the test framework.

Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters StephenLPeters merged commit 8f1a682 into microsoft:master Jul 14, 2020
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 14, 2020
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.5.0-prerelease.200812001 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Narrator, keyboarding, UIA, etc area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
6 participants