Add workaround so ItemsRepeater doesn't leak the result of DataTemplate::Load #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
StephenLPeters
added
area-ItemsRepeater
team-Controls
ranjeshj
reviewed
Aug 6, 2020
dev/Repeater/TestUI/Samples/ItemTemplateSamples/DisposableUserControl.xaml.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcelwgn
reviewed
Aug 7, 2020
marcelwgn
reviewed
Aug 7, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcelwgn
approved these changes
Aug 7, 2020
ranjeshj
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread of #1954 has lots more information, but the short story is that ItemsRepeater has a call to DataTemplate::LoadContent to decide if the template is empty. DataTemplate::LoadContent has a bug (#3057) where if you don't add the result to a UIElementCollection then the returned object will be leaked. The simplest workaround is to just add the result to the ItemsRepeater's own child collection and immediately remove it.
Thanks @chingucoding for the test code. I changed the scenario a little from what you had built because I wanted to verify that all the items get cleaned up.
Fixes #1954