Fix issue with flyouts created in CommandBarFlyout not closing when commandbar closes #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
| // Move around over item to open flyout | ||
| PointerInput.Move(FindElement.ById("ProofingButton"), 5, 5); | ||
| PointerInput.Move(FindElement.ById("ProofingButton"), 6, 5); | ||
| PointerInput.Move(FindElement.ById("ProofingButton"), 5, 6); |
There was a problem hiding this comment.
I made a change yesterday that would allow you to replace this with a click if you wanted to
There was a problem hiding this comment.
Oh right, yes. I don't think there is much benefit in updating this, but I'll use it next time when I write a test in this area.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-Commanding
|
There was a test failure, hopefully it is fixed with the latest changes. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
llongley
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code that closed the flyouts was only run when there were animations, which is a bug if animations are disabled as we leave flyouts open while the CommandBarFlyout is not open anymore.
Thanks @llongley for the pointer in that area!
Motivation and Context
Fixes #1792
How Has This Been Tested?
Add new interaction test.
Screenshots (if appropriate):