NavigationView: Fix crash when launched in Top mode with hierarchical navigation #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
marcelwgn
approved these changes
Aug 20, 2020
dev/NavigationView/NavigationView_ApiTests/NavigationViewTests.cs
Outdated
Show resolved
Hide resolved
ranjeshj
added
area-NavigationView
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Fixed merge conflicts. |
|
@Felix-Dev The pipeline fix just went in, could you please merge master into this PR? |
|
@StephenLPeters Merged with master. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #2759 introduced a regression which manifested itself in an app crash. The app crash happens when the following conditions are met:
MenuItemsSource!= null (and noMenuItems)(Launching the NavigationView in other configurations works as expected.)
How Has This Been Tested?
Tested manually and added API test.