Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView: Fix visual flicker when directly clicking the expand/collapse chevron #3260

Conversation

Felix-Dev
Copy link
Contributor

Description

When a TreeViewItem's expand/collapse chevron is directly clicked, the background of the TreeViewItem visually flickers. See this gif below:
treeview-chevron-flickering

This PR fixes the visual flickering:
treeview-chevron-flickering-fix

How Has This Been Tested?

Tested visually.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Sep 8, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

Is there an associated issue?

@Felix-Dev
Copy link
Contributor Author

@StephenLPeters No associated issue. The PR would have been opened immediately after creating the issue and since the PR seems to be a rather uncontroversial one, I thought a PR alone is enough here. Would you suggest opening an issue in similar cases in the future?

@StephenLPeters
Copy link
Contributor

We normally like to for searching reasons.

@StephenLPeters StephenLPeters merged commit 2766115 into microsoft:master Sep 8, 2020
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/treeview-expandchevron-flickering-fix branch September 8, 2020 22:16
@StephenLPeters StephenLPeters added area-TreeView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 8, 2020
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TreeView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants