Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ApplicationPageBackgroundThemeBrush #3898

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Update ApplicationPageBackgroundThemeBrush #3898

merged 1 commit into from
Jan 7, 2021

Conversation

beervoley
Copy link
Contributor

@beervoley beervoley commented Jan 6, 2021 •
edited
Loading

Update ApplicationPageBackgroundThemeBrush

Description

This PR updates ApplicationPageBackgroundThemeBrush to use SolidBackgroundFillColorBase (to FF202020 in dark theme, FFF3F3F3 in light theme)

@beervoley beervoley requested review from ranjeshj and teaP January 6, 2021 18:52
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 6, 2021
@beervoley beervoley added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 6, 2021
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 7, 2021

@YuliKl as FYI

@ranjeshj ranjeshj merged commit 5c35069 into feature/token-experiment Jan 7, 2021
@ranjeshj ranjeshj deleted the vsiliush/update-backgroundthemebrush branch January 7, 2021 16:33
@karkarl
Copy link
Contributor

karkarl commented Jan 7, 2021 •
edited
Loading

@ranjeshj @YuliKl @beervoley this is a duplicate of DefaultApplicationBackgroundThemeBrush. Furthermore, the default background defined in the specs is SolidBackgroundFillColorTertiaryBrush which is #F9F9F9?

@mdtauk
Copy link
Contributor

mdtauk commented Jan 7, 2021

YAY! This will finally mean the end of Pure Black and Pure White for window backgrounds.

#920 #921

@YuliKl
Copy link

YuliKl commented Jan 7, 2021

@ranjeshj @YuliKl @beervoley this is a duplicate of DefaultApplicationBackgroundThemeBrush. Furthermore, the default background defined in the specs is SolidBackgroundFillColorTertiaryBrush which is #F9F9F9?

@karenbtlai ApplicationPageBackgroundThemeBrush is an older brush from generic.xaml which appears as the default Page background color in the VS UWP app template. We need to change the values of that resource to stop defaulting to pure black/white. And I had checked with design, several times, that the hex values @beervoley listed in the description are correct for the page background.

I'm not sure what this means for DefaultApplicationBackgroundThemeBrush - that might be a brush we no longer need?

@karkarl
Copy link
Contributor

karkarl commented Jan 7, 2021

@ranjeshj @YuliKl @beervoley this is a duplicate of DefaultApplicationBackgroundThemeBrush. Furthermore, the default background defined in the specs is SolidBackgroundFillColorTertiaryBrush which is #F9F9F9?

@karenbtlai ApplicationPageBackgroundThemeBrush is an older brush from generic.xaml which appears as the default Page background color in the VS UWP app template. We need to change the values of that resource to stop defaulting to pure black/white. And I had checked with design, several times, that the hex values @beervoley listed in the description are correct for the page background.

I'm not sure what this means for DefaultApplicationBackgroundThemeBrush - that might be a brush we no longer need?

I see :) let's remove the duplicate brush then?

licanhua pushed a commit that referenced this pull request Jan 8, 2021
@beervoley @licanhua
Update ApplicationPageBackgroundThemeBrush (#3898)
cdab360
@licanhua licanhua mentioned this pull request Jan 8, 2021
Merged
ranjeshj pushed a commit that referenced this pull request Jan 8, 2021
@licanhua @beervoley
Cherry-pick #3898 and #3886 from feature/token-experiment to master (#…
8620603 
…3908)

* Update resources names (#3886)

* Update resources names and fix certificate issue

(cherry picked from commit 022de1b)

* Update ApplicationPageBackgroundThemeBrush (#3898)

Co-authored-by: Vsevolod <sevkorobot@gmail.com>
ranjeshj pushed a commit that referenced this pull request Jan 12, 2021
@licanhua @beervoley
Avoid hard-coded "Segoe MDL2 Assets" (#3923)
99e9139 
* Update resources names (#3886)

* Update resources names and fix certificate issue

(cherry picked from commit 022de1b)

* Update ApplicationPageBackgroundThemeBrush (#3898)

* Avoid hardcoded 'Segoe MDL2 Assets' and use indirect reference for font asset

Co-authored-by: Vsevolod <sevkorobot@gmail.com>
licanhua added a commit that referenced this pull request Jan 14, 2021
@licanhua @beervoley
Remove VerifyRSxxDictionariesWereMergedCorrectly test cases (#3935)
3290f0c 
* Update resources names (#3886)

* Update resources names and fix certificate issue

(cherry picked from commit 022de1b)

* Update ApplicationPageBackgroundThemeBrush (#3898)

* remove VerifyRS2ThemeResourceDictionariesWereMergedCorrectly and other similar test cases

Co-authored-by: Vsevolod <sevkorobot@gmail.com>
@yaira2 yaira2 mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranjeshj ranjeshj ranjeshj approved these changes

@teaP teaP Awaiting requested review from teaP

@StephenLPeters StephenLPeters Awaiting requested review from StephenLPeters

Assignees
No one assigned
Labels
team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beervoley @ranjeshj @karkarl @mdtauk @YuliKl