Update TextBox and related controls #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Could you share images of the changes being made? Will these changes also need to be made for the NumberBox? |
StephenLPeters
added
area-AutoSuggestBox
area-Styling
area-TextBlocks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
approved these changes
Jan 13, 2021
|
This also updates NumberBox as far as it containing a TextBox goes; there may be other adjustments to it coming later. |
Yea, because the buttons when inline with the Textfield, would need to blend well, and the Focused state would need to take this into account too. |
Agreed, that'll be a different PR. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 10, 2022
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update text control colors and borders, as well as the inner buttons inside them (close button, AutoSuggest has a find button, PasswordBox has a peek button).
About TemporaryTextFillColorDisabled: There is some bug where if you change the text foreground, but the RGB part of that color is the same (not the opacity), the color will not visually be updated. We're investigating and will open a bug when we know more, and I'll update the comments in this file with the bug number. As a workaround, for now, I created this temporary color that is just slightly not black (or not white) which does get applied.