Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to Rainbow Backgrounds on CommandBarFlyout and MenuFlyout TestUI pages #5219

Merged
merged 7 commits into from
Nov 10, 2021

Conversation

mdtauk
Copy link
Contributor

@mdtauk mdtauk commented Jun 19, 2021

Description

Tweaks to Rainbow Backgrounds on CommandBarFlyout and MenuFlyout TestUI pages

Motivation and Context

Harder transitions added to the Rainbow Background help to illustrate the blurring from the Acrylic CommandBarFlyouts and MenuFlyouts. This PR is being submitted at the suggestion of @StephenLPeters
#5213

This is my second ever PR and submission to the repo so apologies if I have done something wrong

How Has This Been Tested?

I opened the pages in the MUXTestApp and observed the changes

Screenshots (if appropriate):

image
image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 19, 2021
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This background looks really cool, great idea!

@mdtauk
Copy link
Contributor Author

mdtauk commented Jun 21, 2021

I missed that the CommandBar test page also used the rainbow background, so I have added that now

image

@StephenLPeters StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc area-TestInfrastructure Issue in the test infrastructure (e.g. in Helix scripts) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 21, 2021
@StephenLPeters
Copy link
Contributor

@mdtauk Can you merge in Main to pick up a recent infrasturcture fix that will unblock the pipeline?

@mdtauk
Copy link
Contributor Author

mdtauk commented Jun 21, 2021

@mdtauk Can you merge in Main to pick up a recent infrasturcture fix that will unblock the pipeline?

@StephenLPeters GitHub for Windows says it is merged with Main - is there something else I need to do? I am relatively new to this.
image

Harder transitions added to the Rainbow Background help to illustrate the blurring from the Acrylic CommandBarFlyouts and MenuFlyouts
I forgot to update the rainbow background on the Command Bar page
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor

karkarl commented Nov 8, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl karkarl merged commit 04b7230 into microsoft:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Commanding AppBar, UICommand, MVVM, etc area-TestInfrastructure Issue in the test infrastructure (e.g. in Helix scripts) team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants