[ProgressRing] Remove ProgressRing from UIA tree when it is not active #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
marcelwgn
commented
Sep 20, 2021
| @@ -341,7 +341,8 @@ void ProgressRing::UpdateStates() | |||
| // Swap player source to determinate. | |||
| SetAnimatedVisualPlayerSource(); | |||
| UpdateLottieProgress(); | |||
| } | |||
| } | |||
| winrt::AutomationProperties::SetAccessibilityView(*this, winrt::AccessibilityView::Content); | |||
There was a problem hiding this comment.
We have to do this here since VSS setters can't set this on the "root" control
| @@ -25,6 +25,7 @@ | |||
| <VisualState x:Name="Inactive"> | |||
| <VisualState.Setters> | |||
| <Setter Target="LayoutRoot.Opacity" Value="0" /> | |||
| <Setter Target="LottiePlayer.(AutomationProperties.AccessibilityView)" Value="Raw" /> | |||
There was a problem hiding this comment.
Setting this since we don't want the animation to still exist in the UIA tree.
ranjeshj
reviewed
Sep 21, 2021
StephenLPeters
approved these changes
Sep 21, 2021
ranjeshj
added
area-Progress
StephenLPeters
approved these changes
Sep 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
🎉 Handy links: |
This was referenced Apr 14, 2022
Merged
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing ProgressRing from UIA tree when it is not active.
Motivation and Context
Closes #2741
How Has This Been Tested?
Tested with narrator, control does not get announced anymore.
Screenshots (if appropriate):