CommandBarFlyout crash fix #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
team-Controls
marcelwgn
approved these changes
Sep 21, 2021
|
@chingucoding, no repro no test :-( |
Fair enough. |
RBrid
added a commit
that referenced
this pull request
Oct 14, 2021
This reverts commit 03a091b. Undoing CommandBarFlyout changes because of crash regressions.
RBrid
added a commit
that referenced
this pull request
Oct 14, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandBarFlyout fix for internal bug 35782367.
Crash dumps indicated that the Hide() call was causing a null ref exception. The call occurs when the closing animation completes.
My assumption is that in rare cases the 'this' pointer is no longer valid by the time the closing animation completed and using a weak reference to the CommandBarFlyout instead solves the issue. I have not been able to repro the crash though after trying to get the CommandBarFlyout to be garbage-collected before the Hide call. So I was not able to confirm my assumption.