Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ HC ] [ ToggleSwitch ] [ Settings ] Eye control toggle button icon is not visible on applying Desert Contrast theme. #6030

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[ HC ] [ ToggleSwitch ] [ Settings ] Eye control toggle button icon is not visible on applying Desert Contrast theme. #6030

merged 1 commit into from
Oct 4, 2021

Conversation

tashatitova
Copy link
Contributor

A pretty severe bug here. HC brushes use wrong colors, and on top of that, we need colors, not brushes, for the animations to work and for outline to display properly. So the outline was missing completely.
before

Fixing this by updating all HC brushes to point directly to HC brushes and colors (mostly colors).

HC desert:
after-desert

HC aqua (default):
https://user-images.githubusercontent.com/29714167/135921793-8051f022-2cd9-477c-b64e-176373f75474.mp4

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 4, 2021
@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters merged commit e4d6f1a into main Oct 4, 2021
@StephenLPeters StephenLPeters deleted the user/tatito/toggleswitch branch October 4, 2021 23:45
@StephenLPeters StephenLPeters added accessibility Narrator, keyboarding, UIA, etc area-ToggleSwitch team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 4, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@marksfoster marksfoster marksfoster approved these changes

@karkarl karkarl Awaiting requested review from karkarl

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

@teaP teaP Awaiting requested review from teaP

Assignees
No one assigned
Labels
accessibility Narrator, keyboarding, UIA, etc area-ToggleSwitch team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tashatitova @StephenLPeters @marksfoster