Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Radio Button ] [ HC ] Style updates (remainder) #6043

Merged
merged 2 commits into from
Oct 6, 2021
Merged

[ Radio Button ] [ HC ] Style updates (remainder) #6043

merged 2 commits into from
Oct 6, 2021

Conversation

tashatitova
Copy link
Contributor

Updating checked and unchecked hover and press states for the radio button to match spec:
RadioButton

Cleaning up brushes to point directly to system brush or color (depending on animation)

radio.mp4

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 5, 2021
@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova tashatitova merged commit 4283cb8 into main Oct 6, 2021
@tashatitova tashatitova deleted the user/tatito/radio branch October 6, 2021 21:21
@ranjeshj ranjeshj added area-RadioButtons area-Styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 6, 2021
@MajorXAML
Copy link

@tashatitova
Hello, could you please tell me where this screenshot is from?
Because there are serious differences between the figma toolkit and WinUI #6303 Plus in your screenshot the buttons use a completely different color.

I'm trying to port some elements to wpf and am facing the problem that some elements and colors are different in winui and figma toolkit. It's very confusing :/

@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksfoster marksfoster marksfoster approved these changes

@karkarl karkarl Awaiting requested review from karkarl

@beervoley beervoley Awaiting requested review from beervoley

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

@teaP teaP Awaiting requested review from teaP

Assignees
No one assigned
Labels
area-RadioButtons area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tashatitova @MajorXAML @marksfoster @ranjeshj