Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SplitButton] Fix jumping chevron on touch hovering/pressing… #6087

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[SplitButton] Fix jumping chevron on touch hovering/pressing… #6087

merged 1 commit into from
Oct 26, 2021

Conversation

eugenegff
Copy link
Contributor

SplitButton extends secondary button to the whole control area for the touch, but chevron should be still aligned to the right side

image

@teaP @StephenLPeters FYI

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 12, 2021
@eugenegff eugenegff force-pushed the SplitButtonCommandBarStyle-jumping-chevron-fix branch from bf0f94b to 02921b8 Compare October 12, 2021 15:32
@StephenLPeters
Copy link
Contributor

What do you mean when you say "The commandbar can now have simultaneous split buttons with chevrons on left and right sides"? do you have a picture?

@eugenegff
Copy link
Contributor Author

eugenegff commented Oct 13, 2021 •
edited
Loading

What do you mean when you say "The commandbar can now have simultaneous split buttons with chevrons on left and right sides"? do you have a picture?

Several SplitButtons in CommandBar could have inconsistent chevron placement - those that were last hovered by mouse had it on the right, and those that were hovered/pressed by finger - on the left.

image

@StephenLPeters
Copy link
Contributor

ah and this change should fix that issue correct?

@eugenegff
Copy link
Contributor Author

ah and this change should fix that issue correct?

exactly - it alignes chevron to the right, as does other 4 variations of SplitButton style in MUX, except the guilty one

@karkarl
Copy link
Contributor

karkarl commented Oct 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-SplitButton team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 20, 2021
@eugenegff
Copy link
Contributor Author

@StephenLPeters @karenbtlai so, can we convert the thumbs up emoji to formal approval, merge this PR and move to more interesting things? :)

@StephenLPeters StephenLPeters merged commit f8616d4 into microsoft:main Oct 26, 2021
@StephenLPeters StephenLPeters added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Oct 26, 2021
@eugenegff eugenegff deleted the SplitButtonCommandBarStyle-jumping-chevron-fix branch October 26, 2021 17:03
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-SplitButton needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugenegff @StephenLPeters @karkarl