Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Menu Flyout ] [ HC ] Style updates (remainder) #6146

Merged
merged 3 commits into from
Oct 26, 2021
Merged

[ Menu Flyout ] [ HC ] Style updates (remainder) #6146

merged 3 commits into from
Oct 26, 2021

Conversation

tashatitova
Copy link
Contributor

  • Updating rest, hover, pressed foreground for regular and open items in menu and sub-menu, including icons and accelerator text
  • Added visual states to radio flyout item as accelerator text wasn't updated at all
  • Simplified the rest of the brushes to match to 8 HC colors

Spec on the left:
MenuFlyout

Updated result:

Menu.mp4

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 22, 2021
@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova
Copy link
Contributor Author

@StephenLPeters please take a look

@StephenLPeters StephenLPeters added area-Accessibility area-Menus team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 25, 2021
@StephenLPeters StephenLPeters merged commit c0f300e into main Oct 26, 2021
@StephenLPeters StephenLPeters deleted the user/tatito/menu branch October 26, 2021 01:32
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@karkarl karkarl Awaiting requested review from karkarl

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

@marksfoster marksfoster Awaiting requested review from marksfoster

Assignees
No one assigned
Labels
area-Accessibility area-Menus team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashatitova @StephenLPeters