Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IPopup4 to Private namespace #6165

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Move IPopup4 to Private namespace #6165

merged 1 commit into from
Oct 26, 2021

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Oct 26, 2021

We did not intend to ship IPopup4 and IAutomationPropertiesStatics9 as part of the M.U.X nupkg, since these are intended to be internal to MUX.

This was causing issues with WACK verification, since the UUIDs are duplicates of interfaces in the Windows 11 SDK.

The fix is to move these types to the Private namespace so they don't end up in the M.U.X.winmd.

@kmahone kmahone requested a review from llongley October 26, 2021 21:15
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 26, 2021
@kmahone
Copy link
Member Author

kmahone commented Oct 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone mentioned this pull request Oct 26, 2021
Closed
@kmahone
Copy link
Member Author

kmahone commented Oct 26, 2021

I have filed this issue to come up with a solution to make things less confusing to avoid similar issues in the future:
Usage of MUX_INTERNAL attribute in repo is confusing #6166

@kmahone kmahone merged commit 54aea75 into main Oct 26, 2021
@kmahone kmahone deleted the user/kmahone/ipopup4 branch October 26, 2021 23:50
@ranjeshj ranjeshj added area-NugetPackage Issue with the nuget package developer experience (e.g. build error, missing files) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 28, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@llongley llongley llongley approved these changes

Assignees
No one assigned
Labels
area-NugetPackage Issue with the nuget package developer experience (e.g. build error, missing files) team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmahone @StephenLPeters @llongley @ranjeshj