[BreadcrumbBar] Fix issue where setting ItemsSource was not respected #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
marcelwgn
commented
Nov 15, 2021
Comment on lines
+151
to
+155
| if (const auto& itemsRepeater = m_itemsRepeater.get()) | ||
| { | ||
| m_itemsIterable = winrt::make_self<BreadcrumbIterable>(ItemsSource()); | ||
| itemsRepeater.ItemsSource(*m_itemsIterable); | ||
| } |
There was a problem hiding this comment.
I copied this over from the OnBreadcrumbBarItemsSourceCollectionChanged handler, why is the collection items changed handler even setting the ItemSource? Was this intentional or just an oversight?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
removed
the
needs-triage
StephenLPeters
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When itemssource was changed, the itemsrepeater was not provided the new itemssource.
Motivation and Context
Closes #5986
How Has This Been Tested?
Added new API test
Screenshots (if appropriate):