Revert #5872 #6552
Merged
Revert #5872 #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ted test failure in CalendarView. This test is failing across the board of Lab Runs for multiple PR's and I am attributing the error to a change in the lab environment. I don't think it is worth the time to verify where this failure is originating.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-Dialogs
team-Controls
kmahone
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RS3+ ContentDialog places the whole Content Dialog in the popup that displays it. Before this it would place only the content in the popup. The "BackgroundElement" child element of the ContentDialog is the root of what users actually see as the dialog, and that's what needs to be MaxWidth limited (and it is still correctly limited with the regression). "BackgroundElement" is then centered within the outer ContentDialog, and so when the whole ContentDialog has a size limitation, it can't extend all the way from the left window border to the right. The ContentDialog is left and top aligned within the popup, even though its HorizontalAlignment is Stretch. So "BackgroundElement" is centered within a left-aligned box, making the dialog left aligned from the user's perspective. The regressing change makes the ContentDialog's MaxWidth match BackgroundElement's, and so it's right up against the left edge of the window.
We don't have a good way to work around this behavior from Winui2 so I am reverting the change.