Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView fixes #6632

Merged
merged 2 commits into from
Jan 31, 2022
Merged

TabView fixes #6632

merged 2 commits into from
Jan 31, 2022

Conversation

ojhad
Copy link
Contributor

@ojhad ojhad commented Jan 21, 2022

Description

This PR fixes the following bugs:

  1. When selecting a partially hidden tab when in overflow state, the full tab does not come into view (end of the tab is cut off from view). Updated StartBringIntoView() to add pixel padding to the TargetRect width.
  2. Tab is cut off when creating a new tab where the last tab is selected and changes to scrolling mode.
  3. Rearranging a selected tab does not keep the tab in view after being dropped

Motivation and Context

Fixes internal bugs 37609293, 37608918, 37608607

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 21, 2022
@ojhad
Copy link
Contributor Author

ojhad commented Jan 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad ojhad mentioned this pull request Jan 21, 2022
Closed
@ojhad
Copy link
Contributor Author

ojhad commented Jan 27, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad ojhad requested review from RBrid and karkarl January 27, 2022 19:47
@ojhad ojhad merged commit f4e6550 into main Jan 31, 2022
@ojhad ojhad deleted the user/ojhad/tabviewfixes branch January 31, 2022 19:13
kmahone added a commit that referenced this pull request Feb 18, 2022
@kmahone
Revert "TabView fixes (#6632)"
a99ef9d 
This reverts commit f4e6550.
@StephenLPeters StephenLPeters added area-TabView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 2, 2022
@RBrid RBrid mentioned this pull request Apr 18, 2022
Merged
@zadjii-msft zadjii-msft mentioned this pull request Apr 13, 2023
Closed
@karkarl karkarl mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahone kmahone kmahone approved these changes

@RBrid RBrid Awaiting requested review from RBrid

@karkarl karkarl Awaiting requested review from karkarl

Assignees
No one assigned
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ojhad @kmahone @StephenLPeters