Add new WebView2 tests, add focus logging to WebView2 tests, avoid potential flicker when removing #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ave to click so low on the screen (test doesn't seem to like that)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-WebView
team-Rendering
|
@krschau is this ready for review? @DmitriyKomin can you take a look? In reply to: 1035345005 |
krschau
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check in CheckAndUpdateWebViewPosition() to not do work when the WebVIew2 is not loaded, to prevent potential visual flicker.
Adds two new WebView2 tests: CreateWebView2OffTreeTest and HtmlDropdownTest. Splits NavigationStartingTest into two tests, NavigationStartingTest and NavigationStartingInvalidTest because as one long test they can sometimes timeout.
Adds logging for the focus and blur events in some of the test web pages.