Adding MicaController RuntimeProfiler recording #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -61,7 +61,7 @@ | |||
| </ScrollViewer> | |||
| <StackPanel Orientation="Horizontal" Grid.Row="2" HorizontalAlignment="Center"> | |||
| <CheckBox x:Name="LongAnimationsDisabled" AutomationProperties.AutomationId="LongAnimationsDisabled" Content="Long Animations Disabled" Checked="LongAnimationsDisabled_Checked" Unchecked="LongAnimationsDisabled_Unchecked" Margin="10,0,0,0"/> | |||
|
|
|||
| <Button x:Name="GarbageCollection" Content="GarbageCollection" VerticalAlignment="Center" Click="GarbageCollection_Click" Margin="5"/> | |||
There was a problem hiding this comment.
Should this be available when within a test page as well? like the render in lab frame dimensions button?
There was a problem hiding this comment.
I added this here so you can hit the button, go to a test page, come back, hit the button again, and there should be no leak.
But I see that moving it next to "Enable RTL" would allow garbage collection within the test page also.
There was a problem hiding this comment.
OK - I moved it to the TestFrame level.
StephenLPeters
approved these changes
Feb 11, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-DevInternal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three things happening in this PR:
Recording the creation of the MicaController type for telemetry like we do with other WinUI 2.x controls/components. This is for internal work item 38097087.
Adding a convenient garbage collection button to MuxControlsTestApp's main page. This comes handy when investigating memory leak bugs in the various test pages.
Fixing the CalendarView test page which was broken after changing the time zone in the Settings app on the fly. The test CalendarView UI would not reflect the change correctly.