[ CalendarDatePicker ] Remove unnessessary focus state #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashatitova
requested review from
StephenLPeters,
karkarl,
ranjeshj,
teaP and
marksfoster
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I don't think we can't remove VisualStates that already exist in the resource dictionary. It will cause the app to crash if someone is referencing it. @StephenLPeters |
marksfoster
approved these changes
Feb 17, 2022
|
@karenbtlai @StephenLPeters I can sure add these brushes back in, but wouldn't it feel like a bug if someone overrides them but they change nothing? better than crashing I suppose but not ideal either |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalendarDatePicker button was changing background on focus, breaking the contrast ratio.
Removing any action on focus as per design guidance.
Before:
Updated:
Hover updated:
