Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ NavigationView ] Chevron does not meet contrast requirements in Aquatic High Contrast theme #6739

Merged
merged 9 commits into from
Feb 18, 2022
Merged

[ NavigationView ] Chevron does not meet contrast requirements in Aquatic High Contrast theme #6739

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
70d9b3b
date pickers
tashatitova Nov 3, 2021
a297304
adding time picker and flyout theming
tashatitova Nov 3, 2021
861faee
update background smoke for hc
tashatitova Nov 9, 2021
749cdd7
Merge branch 'user/tatito/dialog'
tashatitova Nov 9, 2021
f053b69
Merge branch 'main' of https://github.com/microsoft/microsoft-ui-xaml
tashatitova Nov 23, 2021
bc6b912
Merge branch 'main' of https://github.com/microsoft/microsoft-ui-xaml
tashatitova Feb 9, 2022
da78588
Merge branch 'main' of https://github.com/microsoft/microsoft-ui-xaml
tashatitova Feb 15, 2022
964303f
Merge branch 'main' of https://github.com/microsoft/microsoft-ui-xaml
tashatitova Feb 16, 2022
8000b60
adding foreground states for chevron
tashatitova Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dev/NavigationView/NavigationView_rs1_themeresources.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@
<VisualState.Setters>
<Setter Target="LayoutRoot.Background" Value="{ThemeResource NavigationViewItemBackgroundPointerOver}" />
<Setter Target="Icon.Foreground" Value="{ThemeResource NavigationViewItemForegroundPointerOver}" />
<Setter Target="ExpandCollapseChevronIcon.Foreground" Value="{ThemeResource NavigationViewItemForegroundPointerOver}" />
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource NavigationViewItemForegroundPointerOver}" />
<Setter Target="Icon.(local:AnimatedIcon.State)" Value="PointerOver"/>
</VisualState.Setters>
Expand All @@ -592,6 +593,7 @@
<VisualState.Setters>
<Setter Target="LayoutRoot.Background" Value="{ThemeResource NavigationViewItemBackgroundPressed}" />
<Setter Target="Icon.Foreground" Value="{ThemeResource NavigationViewItemForegroundPressed}" />
<Setter Target="ExpandCollapseChevronIcon.Foreground" Value="{ThemeResource NavigationViewItemForegroundPressed}" />
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource NavigationViewItemForegroundPressed}" />
<Setter Target="Icon.(local:AnimatedIcon.State)" Value="Pressed"/>
</VisualState.Setters>
Expand All @@ -600,13 +602,15 @@
<VisualState.Setters>
<Setter Target="LayoutRoot.Background" Value="{ThemeResource NavigationViewItemBackgroundSelected}" />
<Setter Target="Icon.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelected}" />
<Setter Target="ExpandCollapseChevronIcon.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelected}" />
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelected}" />
</VisualState.Setters>
</VisualState>
<VisualState x:Name="PointerOverSelected">
<VisualState.Setters>
<Setter Target="LayoutRoot.Background" Value="{ThemeResource NavigationViewItemBackgroundSelectedPointerOver}" />
<Setter Target="Icon.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelectedPointerOver}" />
<Setter Target="ExpandCollapseChevronIcon.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelectedPointerOver}" />
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelectedPointerOver}" />
<Setter Target="Icon.(local:AnimatedIcon.State)" Value="PointerOver"/>
</VisualState.Setters>
Expand All @@ -615,6 +619,7 @@
<VisualState.Setters>
<Setter Target="LayoutRoot.Background" Value="{ThemeResource NavigationViewItemBackgroundSelectedPressed}" />
<Setter Target="Icon.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelectedPressed}" />
<Setter Target="ExpandCollapseChevronIcon.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelectedPressed}" />
<Setter Target="ContentPresenter.Foreground" Value="{ThemeResource NavigationViewItemForegroundSelectedPressed}" />
<Setter Target="Icon.(local:AnimatedIcon.State)" Value="Pressed"/>
</VisualState.Setters>
Expand Down Expand Up @@ -1168,6 +1173,7 @@
Height="12"
RenderTransformOrigin="0.5, 0.5"
x:Name="ExpandCollapseChevronIcon"
Foreground="{ThemeResource NavigationViewItemForeground}"
HorizontalAlignment="Center"
VerticalAlignment="Center"
AutomationProperties.AccessibilityView="Raw"
Expand Down