Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid layout cycle changing SelectedBackgroundPath Path size within TabViewItem::OnSizeChanged #6747

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Avoid layout cycle changing SelectedBackgroundPath Path size within TabViewItem::OnSizeChanged #6747

merged 1 commit into from
Feb 20, 2022

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Feb 19, 2022

Updating TabGeometry asynchronously rather than synchronously in TabViewItem::OnSizeChanged to avoid possible layout cycles.

@RBrid RBrid self-assigned this Feb 19, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 19, 2022
@RBrid
Copy link
Contributor Author

RBrid commented Feb 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RBrid RBrid merged commit da8b658 into main Feb 20, 2022
@RBrid RBrid deleted the user/regisb/TabViewRegressionFix2 branch February 20, 2022 02:01
@ranjeshj ranjeshj added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranjeshj ranjeshj ranjeshj approved these changes

@kmahone kmahone Awaiting requested review from kmahone

Assignees

@RBrid RBrid

Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RBrid @ranjeshj