Fix issue where setting IsPaneButtonVisible on NavigationView could end up in faulty rendering of pane toggle button #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
StephenLPeters
added
area-NavigationView
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
approved these changes
Mar 5, 2022
MartinZikmund
added a commit
to unoplatform/uno
that referenced
this pull request
Sep 5, 2023
MartinZikmund
added a commit
to unoplatform/uno
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The margin for the pane toggle button was not correctly be updated correctly because the function updating the margin of the pane toggle button was not called. This PR fixes that.
Motivation and Context
Closes #6493
How Has This Been Tested?
Tested manually:
Note that the header moving is because we are switching between displaymodes.
Screenshots (if appropriate):