[TabView] Update high contrast colors | MicaAlt colors - update high contrast colors #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashatitova
requested review from
karkarl,
beervoley,
ranjeshj,
teaP and
marksfoster
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marksfoster
approved these changes
Mar 4, 2022
|
|
beervoley
approved these changes
Mar 4, 2022
…g on press on tab vs press on close button - fixed now
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This should be Refers to: dev/TabView/TabView_themeresources.xaml:128 in fbfd705. [](commit_id = fbfd705, deletion_comment = False) |
karkarl
reviewed
Mar 4, 2022
karkarl
requested changes
Mar 4, 2022
karkarl
approved these changes
Mar 4, 2022
StephenLPeters
added
accessibility
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a high contrast pass and fixed some bugs on tabs, selected tab, outlines, tab close button.
Added a border for the close button in high contrast as usually required by accessibility.
Updated MicaAlt colors to proper background in high contrast as these are usually backgrounds and we want to avoid flooding large areas with highlight color.
Before:
Updated, multiple hc themes:
TabView-after.mp4