Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationViewItemRevokers use WeakRef this pointers #6803

Closed
wants to merge 4 commits into from
Closed

NavigationViewItemRevokers use WeakRef this pointers #6803

wants to merge 4 commits into from

Commits on Mar 8, 2022

  1. Attempt to fix issue with exception being thrown during cleanup.

    @StephenLPeters
    StephenLPeters committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    25f793b View commit details
    Browse the repository at this point in the history

  2. Swich from tracking NVI's to just using a weak_ref this pointer.

    @StephenLPeters
    StephenLPeters committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    79fb8da View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Add an API test that reproduces the issue without the present fix.

    @StephenLPeters
    StephenLPeters committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    c9c9622 View commit details
    Browse the repository at this point in the history

  2. Fix test name

    @StephenLPeters
    StephenLPeters committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    fbc9643 View commit details
    Browse the repository at this point in the history