Fix F6 unable to return from teaching tip in xaml island. #6807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AcceleratorKeyClicked (when it can) because the later is not available in islands scenarios.
…rnt from the controls xaml root.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…accelerator key for F6 focus movement.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
area-TeachingTip
team-Controls
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…lable. Add some comments and remove dead code
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues blocking this functionality in islands scenarios.
First there is a platform bug which caused the PreviewKeyDown event handler to not be hit when focus was in a popup. This issue was fixed in winui3 recently but we will not be porting that fix to system xaml. To work around this we need to attach the handler to the root element in the popup as well as the XamlRoot.Content.
Second, we were using the FocusManager.GetFocusedElement method in the handler which doesn't work in xaml island scenarios. There we need to use the 19h1+ version of the API with the XamlRoot parameter.
I've validated the fix with our test suite for non-islands scenarios. and with a custom WPF app for the island case.