Delay load Hierarchical NavViewItem elements #6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
changed the title
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
requested changes
Mar 11, 2022
dev/NavigationView/NavigationView_ApiTests/NavigationViewTests.cs
Outdated
Show resolved
Hide resolved
dev/NavigationView/NavigationView_ApiTests/NavigationViewTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Mar 11, 2022
ojhad
added
area-NavigationView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defers the loading of
NavigationViewItemMenuItemsHostandExpandCollapseChevronrelated elements to only when they are needed in the Hierarchical Nav Scenario. This slightly reduces the xaml tree size when using NavigationViewItems without hierarchy.Motivation and Context
Internal bug 37681669