Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting product change made for 'TabView gap between active tab and active content fix #6644' #6936

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Apr 5, 2022

The TabViewItem change made in #6644 introduced a regression worse than the pbm it fixed. So reverting it & we will be working on finding a better fix.

The regression was that in some cases the TabViewItem would constantly grow incrementally by 0.5px.

Internal bug 37332027 will be reactivated.

@RBrid RBrid requested review from ojhad, karkarl and ranjeshj April 5, 2022 23:17
@RBrid RBrid self-assigned this Apr 5, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 5, 2022
@RBrid
Copy link
Contributor Author

RBrid commented Apr 5, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RBrid RBrid merged commit e59614e into main Apr 6, 2022
@RBrid RBrid deleted the user/regisb/TabViewItemRevert2 branch April 6, 2022 01:01
kmahone pushed a commit that referenced this pull request Apr 6, 2022
@ojhad ojhad added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants