Fixing NavigationView UIA set logic #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince there's no difference between the logic in left or top nav anymore.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
area-NavigationView
ojhad
approved these changes
Apr 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MartinZikmund
added a commit
to unoplatform/uno
that referenced
this pull request
Sep 5, 2023
MartinZikmund
added a commit
to unoplatform/uno
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left nav currently has faulty logic to calculate the position in set and size of set, relating to the way in which we count what element we're iterating on. The top nav scenario has the correct logic, and there isn't anything remaining that differentiates the left and top nav here anymore, so I've consolidated both to the same logic. I've added a test scenario to ensure that those are now calculated correctly, as well.