Fixing UIA names surrounding Value from HSV #6948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cases, "brightness" is also included to ensure that accessible users know what is meant by "value", when there aren't other hints.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
approved these changes
Apr 8, 2022
ojhad
added
area-ColorPicker
area-Accessibility
and removed
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Value" wasn't used as the UIA name associated with HSV since the concern was that "value" could be considered confusing by low-vision accessible users since without the broader context, it wasn't clear it meant the V in HSV rather than just any old value, so we used the equivalent "Brightness" instead. However, UIA names need to contain the full string of any attached label, so I've updated things to read "Value (Brightness)" instead. Also, in cases where there's the context of hue and saturation being present as well, I updated things to just read "Value", for consistency.