Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuBar Keyboard Accessibility Fixes #6953

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Conversation

bkudiess
Copy link
Contributor

@bkudiess bkudiess commented Apr 8, 2022

Fixes 3 issues with keyboard in MenuBar:

  • Enable opening a submenu in the MenuFlyout with the arrow keys.
  • Fixes keyboard focus from pointer to programmatic.
  • Changes MenuBarItems to be able to cycle through using arrow keys.

Fixes internal issues: 36685596, 36629906 and 38190286

…menu-item, upon activating 'Status bar' & 'Word wrap' present in 'View' menu item.
…ving in cycle among the 'File', 'Edit' & 'View' menu-items, while navigating via 'Left/Right' arrow keys.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 8, 2022
@bkudiess bkudiess requested review from kmahone and RBrid April 8, 2022 22:17
dev/MenuBar/MenuBarItem.cpp Outdated Show resolved Hide resolved
@kmahone
Copy link
Member

kmahone commented Apr 8, 2022

Please add test automation to cover these keyboarding scenarios.


In reply to: 1093413884

@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bkudiess bkudiess merged commit e19d61d into main Apr 12, 2022
@bkudiess bkudiess deleted the user/bakudies/menubar-keyboard-fix branch April 12, 2022 16:58
@ojhad ojhad added area-Menus team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Menus team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants