-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CueStyler: Fix TimedTextPadding being applied incorrectly #9248
base: winui3/release/1.5-stable
Are you sure you want to change the base?
CueStyler: Fix TimedTextPadding being applied incorrectly #9248
Conversation
Compare with TimedTextDisplayAlignment and TimedTextLineAlignment TimedTextDisplayAlignment.Before means Top TimedTextDisplayAlignment.After means Bottom TimedTextLineAlignment.Start means Left TimedTextLineAlignment.End means Right
@bpulliam - What does the removal of the "needs-triage" label mean? What is the outcome of your triage? |
Removing "needs-triage" means we've internally assigned the issue. The current area owner for CueStyler has been asked to review this PR and handle it appropriately. (I'm assuming your change is correct, but the area owner needs to review, test, and carry the change in if that is the case.) There has been some delay here as we're waiting on availability of the area owner. Thanks for your patience. |
Thanks Mike, for the update and clarification, much appreciated! |
A secondary question would be whether the patch can be applied to the WinUI2 tree as well? |
As stated in here, the general policy for WinUI2 bugs is to close them so we can focus on WinUI3. WinUI2 changes add significant extra work, particularly in areas like this change where it requires changes in Windows across multiple releases. However, there can be exceptions, particularly in areas where no workaround is available. This will need discussion once these PRs are fully understood and handled for WinUI3. |
Yes, I understand and have read this (multiple times).
My request was based on the assumption that CueStyler.cpp is largely identical between WinUI2 and WinUI3, in which case it would be straightforward.
The particular area would be Xbox only (so no multiple Windows releases), where no WinUI3 is available. Of course you'll need to weigh these things for making a decision. Maybe it helps that it's a bundle of several issues, all about CueStyler (this PR, the other PR #9224 , #7981 and #9126). :-) |
Compare with TimedTextDisplayAlignment and TimedTextLineAlignment
TimedTextDisplayAlignment.Before means Top
TimedTextDisplayAlignment.After means Bottom
TimedTextLineAlignment.Start means Left
TimedTextLineAlignment.End means Right